Load the .env that was declared, and read brackets as a flag #1
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
azer/samathapi!1
Loading…
Reference in a new issue
No description provided.
Delete branch "azer/env-flags"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two things about configuration here. dotenv has been a dependency since the first commit and is never imported, so a .env file sits there doing nothing and only a shell export ever reaches the process. And everything in process.env is a string, so 'process.env.brackets || false' turned brackets ON for brackets=false exactly as readily as for brackets=true - a non-empty string is truthy. Measured before and after: with brackets=false set, 25 of 25 generated tasks came back containing brackets; after the change, 0 of 25, and brackets=true still gives 25 of 25. A .env placed next to index.js now takes effect, and .gitignore is added so it does not get committed.